Skip to content

fix: implement VoiceChannelMove and rebuild voice state on Ready #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MuDuran wants to merge 1 commit into from
Closed

fix: implement VoiceChannelMove and rebuild voice state on Ready #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions src/events/v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,23 @@ export async function handleEvent(
}

if (event.voice_states) {
// The server only includes channels that currently have voice
// participants, so a channel that just emptied out is silently
// omitted rather than sent with an empty participant list. If we
// only cleared the channels mentioned below, an omitted channel's
// stale entries would survive this reconciliation (and every
// reconnect after it). Clear every known channel up front so the
// loop below is a full rebuild, not a per-channel merge.
for (const channel of client.channels.values()) {
channel.voiceParticipants.clear();
}

for (const state of event.voice_states) {
// Non-creating lookup is safe: channels are always hydrated
// above (see event.channels handling a few lines up) before we
// get here, so there is no channel data left to create from.
const channel = client.channels.get(state.id);
if (channel) {
channel.voiceParticipants.clear();

for (const participant of state.participants) {
channel.voiceParticipants.set(
participant.id,
Expand Down Expand Up @@ -1013,7 +1025,19 @@ export async function handleEvent(
break;
}
case "VoiceChannelMove": {
// todo
const from = client.channels.getOrPartial(event.from);
if (from) {
from.voiceParticipants.delete(event.user);
}

const to = client.channels.getOrPartial(event.to);
if (to) {
to.voiceParticipants.set(
event.state.id,
new VoiceParticipant(client, event.state),
);
}
// todo: event
break;
}
case "UserVoiceStateUpdate": {
Expand Down