fix(createReducer): return action from Dispatch to match Redux types#2712
Open
mmustafasenoglu wants to merge 1 commit into
Open
fix(createReducer): return action from Dispatch to match Redux types#2712mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
The Dispatch type was returning void, which caused TypeScript errors when using createReducer with redux-thunk or other middleware that expect the dispatch to return the action. Fixes streamich#856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Dispatchtype increateReducerwas returningvoid, which caused TypeScript errors when using the hook with redux-thunk or other middleware that expect dispatch to return the action.Fixes #856
Changes
Changed
Dispatch<Action>return type fromvoidtoActionto align with Redux'sDispatchtyping.Testing
Verified that the type change matches Redux's dispatch signature and resolves the TypeScript compilation errors reported in the issue.