fix(useDeepCompareEffect): remove warning for primitive dependencies#2713
Open
mmustafasenoglu wants to merge 2 commits into
Open
fix(useDeepCompareEffect): remove warning for primitive dependencies#2713mmustafasenoglu wants to merge 2 commits into
mmustafasenoglu wants to merge 2 commits into
Conversation
The Dispatch type was returning void, which caused TypeScript errors when using createReducer with redux-thunk or other middleware that expect the dispatch to return the action. Fixes streamich#856
Remove the warning that fires when all dependencies are primitive values. This warning was incorrect because dependencies can change from primitive to non-primitive at runtime, making useDeepCompareEffect the correct choice. The 'no dependencies' warning is preserved as it indicates a likely mistake. Fixes streamich#755
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the warning that fires when all dependencies are primitive values. This warning was incorrect because dependencies can change from primitive to non-primitive at runtime (e.g.,
undefinedto an object), makinguseDeepCompareEffectthe correct choice.The 'no dependencies' warning is preserved as it indicates a likely mistake.
Fixes #755
Changes
Removed the
deps.every(isPrimitive)warning check fromuseDeepCompareEffect.Context
As noted by @streamich (owner): "I think the warnings for primitives in
useDeepCompareEffect(and shallow compare) should be removed." The warning for no dependencies should stay.