Skip to content

fix(assert): treat a pointer to an empty interface as empty #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyush295 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(assert): treat a pointer to an empty interface as empty #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assert/assertions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,12 @@ func isEmptyValue(objValue reflect.Value) bool {
// non-nil pointers are empty if the value they point to is empty
case reflect.Ptr:
return isEmptyValue(objValue.Elem())
// a non-nil interface is empty if the concrete value it holds is empty.
// This also covers a pointer to an interface, whose Elem() has kind
// Interface: without this case such a value would fall through to the
// default and be reported as non-empty (regression from v1.11.0, #1955).
case reflect.Interface:
return isEmptyValue(objValue.Elem())
}
return false
}
Expand Down
5 changes: 5 additions & 0 deletions assert/assertions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1772,6 +1772,9 @@ func Test_isEmpty(t *testing.T) {
True(t, isEmpty((*int)(nil)))
True(t, isEmpty((*string)(nil)))
True(t, isEmpty(new(string)))
// pointer to an interface (regression test for #1955): empty when the
// interface it points to is nil or holds an empty concrete value.
True(t, isEmpty(new(error)))
True(t, isEmpty([]string{}))
True(t, isEmpty([]string(nil)))
True(t, isEmpty([]byte(nil)))
Expand Down Expand Up @@ -1828,6 +1831,8 @@ func Test_isEmpty(t *testing.T) {
True(t, isEmpty(&[2]int{0, 0}))
False(t, isEmpty("something"))
False(t, isEmpty(errors.New("something")))
// pointer to an interface holding a non-empty value (regression #1955)
False(t, isEmpty(func() *error { e := errors.New("boom"); return &e }()))
False(t, isEmpty([]string{"something"}))
False(t, isEmpty(1))
False(t, isEmpty(int(1)))
Expand Down
Loading