Repository navigation
Release v0.3.0 - #14
Merged
Merged
Conversation
A Liquid action with more than one "destination": "wallet" output paid them all to the same address. The shared assembly passes each output the last receive index already used, and AssemblyContext::receive_address documents it as such. BitcoinContext steps past it; ElementsContext handed it straight to LWK, whose address(Some(i)) returns the address at i -- so every output after the first reused the one before it. Before the assembly was shared, lifecycle added the 1 itself; the move dropped it on the Elements side only. ElementsContext now asks for after + 1, as BitcoinContext does. The existing receive_addresses_advance test only covered Bitcoin; elements_receive_addresses_advance runs a real LWK wallet and fails without the fix ((0, 0) for the 2nd and 3rd). Fixes B2 from the PR #12 review.
stringhandler
force-pushed
the
release-v0.3.0
branch
from
October 6, 2026 10:12
18cd19e to
50257b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.