Repository navigation
Fix requires="simplicity" ordering - #18
Merged
Merged
Conversation
requires must name simplicity whenever the manifest needs a Simplicity compiler, so a wallet without one can refuse it up front. Inference only looked at covenant utxo_types; a tapleaf or simf_fn compute, or a programs entry, also compiles a program but went unflagged, so validate passed manifests that such a wallet would accept and then fail partway through. Infer from every program reference via programs::references.
- resolve(): apply simplicity_hl.version only to files no reference versions, after merging per-reference values; it was applied per reference first and reported a false conflict against a programs entry's own version. - A tapleaf/simf_fn compute with "simf": null is rejected; it parsed as naming no program, so the reference escaped pinning and requires inference. - for_script(None) errors that the utxo type has no script, and each lifecycle lookup names the type, instead of a confusing 'covenant.simf was not loaded'. - RefIssue carries a conflict flag; pin_text no longer matches on message text. - Docs: older readers reject newer-patch fields (format changelog); wallets must refuse unpinned manifests, Unpinned::Allow is for dev tooling (decision 0001). - Remove an unused scratch dir in a programs test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.