fix(docs): use absolute URLs for images and links in the npm READMEs - #613
Conversation
npm joins relative README paths onto the repository URL, so the ../..-based paths in the published READMEs resolved to GitHub page addresses: the donation QR code did not render on npm (404) and the LICENSE, CONTRIBUTING and LICENSE.MIT links did not open the files. The npm READMEs now get raw URLs for images and blob URLs for links; the root README keeps relative paths. The template has a separate __ASSET_BASE__ placeholder for images. Closes #612
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: structured-world/gitlab-mcp/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughREADME generation now uses separate bases for links and images. The generated package READMEs use absolute GitHub URLs, while the root README retains relative paths. ChangesNPM README URL updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The package README links and QR image point to the intended repository files, while the root README keeps relative paths. No actionable merge-blocking risk was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |



Summary
npm joins relative README paths onto the repository URL. The READMEs published to npm used
../..-based paths, which resolved to GitHub page addresses: the donation QR code did not render on the npm page (the resolved URL returns 404) and the LICENSE, CONTRIBUTING and LICENSE.MIT links did not open the files.prepare-release.shrenders the npm READMEs (packages/gitlab-mcp,packages/gitlab-mcp-db) with absolute bases:raw.githubusercontent.com/.../HEADfor images,github.com/.../blob/HEADfor links.README.md.inhas a separate__ASSET_BASE__placeholder for images; the regenerated READMEs are included.Testing
READMEs regenerated with
prepare-release.sh; the new image and link URLs return 200 (the QR asimage/svg+xml). The npm page picks the change up with the next published release.Closes #612
Summary by CodeRabbit