Address spearbit audit comments - #4
Merged
Merged
Conversation
- Improve error messages with more context (got/want pattern) - Add critical assumption documentation for token value parity - Use address type in error params instead of IERC20 for clarity - Add Stage[] parameter to InvalidStage error for better debugging - Update tests to match new error signatures
cxkoda
marked this pull request as ready for review
January 21, 2026 13:48
Collaborator
Author
|
botched merge to another branch instead of main. new PR here #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addresstype in error parameters instead ofIERC20for better readabilityStage[]parameter toInvalidStageerror showing valid stages