Keep the SDK working on devices without Play Billing

[ianrumac]

Problem

On a device without Google Play Billing (no Play Store, no signed-in account), the SDK broke even for flows that don't need Play: test mode and custom store products.

• A paywall with one Play product failed entirely, even when its custom products had loaded.
• AutomaticPurchaseController rethrew from its constructor when the billing client couldn't be created, which fails configure().
• AutomaticPurchaseController.purchase() waited forever for a connection that had already failed.
• If creating the billing client threw inside GoogleBillingWrapper, queued product requests were never completed.
• Nothing remembered that billing was unavailable, so every request reconnected, while the failure was cached per product for the life of the process.

Changes

GoogleBillingWrapper tracks a BillingAvailability state (Unknown, Available, Unavailable).

• Once unavailable, requests fail straight away with BillingNotAvailable and queryAllPurchases returns empty, with no reconnect or retries.
• A billing client that can't be created marks billing unavailable and fails the queued requests.
• Availability is probed again when the app returns to the foreground, so signing in to Play later recovers.
• Three transient setup failures in a row (ERROR, SERVICE_UNAVAILABLE, ...) also mark billing unavailable. On devices with a broken Play Store, setup returned ERROR forever, so product requests queued behind the connection and the paywall load never finished. Reconnects carry on, and a later successful setup makes billing available again.
• BillingNotAvailable is no longer cached in the static products cache.
• When a paywall presents without some products because billing is unavailable, a warning lists them.

StoreManager applies one rule in getProducts: when billing is unavailable, the paywall presents with whatever resolved without Play, and only fails when nothing resolved and test mode is off. The two test-mode-only catches in fetchOrAwaitProducts are gone.

Device without billing	Test mode on	Test mode off
Play-only paywall	Presents	Fails with BillingNotAvailable (unchanged)
Mixed paywall	Presents	Presents with the custom products (new)
Custom-only paywall	Presents	Presents

AutomaticPurchaseController no longer throws from its constructor, and purchase() gives a failed connection one more attempt and then returns PurchaseResult.Failed.

Test mode sheets: the modal and the purchase and restore drawers showed square corners behind their rounded backgrounds, because BottomSheetDialog's sheet container has its own opaque background. It's now transparent.

Behaviour changes to note

• Mixed paywalls on a no-billing device now present with their Play products unresolved, so those show without a price.
• AutomaticPurchaseController.purchase() now checks the connection before building the billing flow params.

Testing

• New GoogleBillingWrapperAvailabilityTest and AutomaticPurchaseControllerTest, plus two new StoreManagerTest cases.
• ./gradlew :superwall:testDebugUnitTest passes (1334 tests). Instrumented test sources compile but were not run.
• On-device: a lim.run Android 15 phone and a local Pixel 8 emulator, both with the Play Store disabled (pm disable-user com.android.vending). Billing reports BILLING_UNAVAILABLE and nothing crashes. In test mode, the modal shows, a Play-only paywall presents with test-catalog prices, and a simulated purchase completes (transaction_complete, status becomes active).
• Also on a lim.run phone with the Play Store enabled (microG-based, no account): setup fails with ERROR. Before the transient-failure change, a normal paywall hung with no presentation result. Now it fails with the billing error, and the test mode flow passes.
• The sheet corner fix was checked on both test_app (framework theme) and the sample app (Theme.MaterialComponents).
• New Maestro flow test_app/maestro/testmode/no_billing_test_mode.yaml covers that path and passes on the lim.run phone. It needs the Play Store disabled first, so it isn't in config.yaml's default flows.
• No CHANGELOG entry yet, since 2.8.4 is already tagged and the next version isn't set.

🤖 Generated with Claude Code

[pullfrog]

ℹ️ No critical issues — a few rough edges inline.

Reviewed changes

Reviewed the whole PR: the new billing-availability state in GoogleBillingWrapper, the null-safe AutomaticPurchaseController, the partial-presentation rule in StoreManager.getProducts, and the new tests. I checked that each new test would fail against the old behaviour, and that a mixed paywall's unresolved Play product fails at purchase time with PurchaseResult.Failed("Product not found") instead of hanging.

• BillingAvailability state: once setup reports BILLING_UNAVAILABLE/FEATURE_NOT_SUPPORTED, or createBillingClient throws, requests fail straight away through executeRequestOnUIThread. Billing is probed again the next time the app comes to the foreground.
• Per-product failure cache removed: BillingNotAvailable is no longer written to the static productsCache, so billing that becomes available later isn't hidden by an old failure.
• AutomaticPurchaseController hardening: creating the client can no longer fail configure(), and purchase() retries a failed connection once with a 10s limit, then returns Failed.
• StoreManager rule: fetchOrAwaitProducts returns billingUnavailable instead of throwing it. getProducts now fails only when nothing resolved and test mode is off.

ℹ️ Nitpicks

• The instrumented GoogleBillingWrapperTest still describes the removed cache (test_billing_not_available_is_cached, test_multiple_products_cached_on_billing_not_available, "Should be BillingNotAvailable from cache", and the "Products cache" region header). These tests still pass, but only through the new fast-fail path in executeRequestOnUIThread, so the names now describe behaviour that no longer exists.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

ℹ️ No blockers. One minor suggestion inline about the sheet corner fix.

Reviewed changes

This review covers what changed since the last Pullfrog review (b75ed4d): the fix for the test mode sheet corners and the new test_app flow for a device without Play Billing. The billing, StoreManager, and AutomaticPurchaseController code is unchanged, so the three earlier threads are still open.

• Transparent sheet container: added BottomSheetDialog.setSheetContent, which clears the background of design_bottom_sheet. TestModeModal, TestModePurchaseDrawer and TestModeRestoreDrawer now use it.
• test_app "Configure with test mode": added an option to configureWithoutPC that sets TestModeBehavior.ALWAYS, plus a button that calls it.
• Maestro no_billing_test_mode.yaml: added an opt-in flow (tag no_billing) that covers test mode, a Play-only paywall and a simulated purchase on a device with the Play Store disabled.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

ℹ️ No blockers. One suggestion inline about the partial result being cached.

Reviewed changes

This review covers what changed since the last Pullfrog review (c6a6241): fixes for the earlier review comments, and the new rule that marks billing unavailable after repeated transient setup failures. All four earlier threads are fixed and resolved.

• Transient setup failure limit: added MAX_TRANSIENT_SETUP_FAILURES = 3. After three transient setup results in a row (ERROR, SERVICE_UNAVAILABLE, ...), billing is marked unavailable and queued requests fail. Reconnects with backoff carry on, and the counter resets on OK and on the foreground re-probe. The two new tests would fail against the old behaviour.
• Narrowed public API: BillingAvailability and GoogleBillingWrapper.availability are now internal.
• Partial presentation log: StoreManager.getProducts now logs a LogLevel.warn with the product ids that didn't resolve.
• Sheet background timing: setSheetContent now clears the container background in doOnLayout. That runs after BottomSheetBehavior.onLayoutChild swaps in its MaterialShapeDrawable, so it also works on Material-themed hosts.
• Comment and test wording: the awaitGetProducts.onError comment and the instrumented GoogleBillingWrapperTest names now describe the fast-fail behaviour instead of the removed cache.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

✅ No new issues found. The open thread about the partial result being cached is fixed.

Reviewed changes

This review covers what changed since the last Pullfrog review (4bac825). Apart from coverage badge updates, that's one commit, and it fixes the thread about a partial load being cached for the whole session.

• Partial loads now retry: when billing is unavailable and some products didn't resolve, StoreManager.getProducts now sets paywall.productsLoadingInfo.failAt. On the next request, PaywallRequestManager sees failAt on the cached paywall and runs addProducts again, so Play prices appear once billing is back.
• Retry stays cheap without billing: on a device that really has no billing, each retry finds the custom products already cached, so fetchAndCacheCustomProducts makes no /products call, and executeRequestOnUIThread fails the Play lookup straight away. PaywallProductsLoad still reports Complete, with productsLoadFailTime set.
• Tests: the mixed-paywall test now asserts that failAt is set, which would fail without this fix. A new test checks that a second getProducts call returns the Play product once billing works, which proves StoreManager doesn't cache the BillingNotAvailable error.

  ^{｜ View workflow run ｜ Using Claude Opus ｜ 𝕏}