fix: prevent global fallback after DWARF lookup errors - #303
Merged
Conversation
Return typed unavailable, ambiguous, and query failures from local variable lookup. Allow global fallback only when a local lookup succeeds without a binding, so diagnostic wording cannot change name resolution. Apply the same rule to scalar and member access and add regression coverage for missing, unavailable, ambiguous, and failed queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local DWARF lookup errors could fall back to a same-named global, with diagnostic prefixes deciding which failures blocked fallback. Return typed unavailable, ambiguous, and query failures, and permit global fallback only when a successful local lookup reports no binding. Scalar and member access now propagate PC resolution and lookup errors.
Add selection tests for missing, unavailable, and ambiguous bindings, plus a compilation regression for scalar and member access at a PC without a DWARF function scope. The regression verifies that a failed local query is rejected even when a matching global exists, while valid global lookups still compile.
Validation completed on this patch:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warnings -D clippy::undocumented_unsafe_blockscargo test -p ghostscope-dwarf -p ghostscope-compiler --lib— 494 passed.cargo test -p ghostscope-dwarf --test global_binding— 3 passed.29a33dfb2302— 362 passed, exit 0, including the new regression.