Repository navigation
Normalize keystore seed phrases before deriving keys - #223
Draft
hippocampusSK wants to merge 2 commits into
Draft
hippocampusSK wants to merge 2 commits into
hippocampusSK wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y7T5QKWXE2vQmr4U7aSQak
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y7T5QKWXE2vQmr4U7aSQak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seed phrases pasted with tabs, double spaces, non-breaking spaces or a trailing newline could fail to import or quietly open a different, empty wallet.
The keystore wallet now cleans up the phrase the same way the SDK does before deriving any key, so a messy paste opens the same wallet as the clean phrase.
Phrases with a wrong checksum are rejected up front, and phrase validation follows the same rules.
Needs the SDK release that includes swapkit/sdk#491.
Linear: API-4243
Generated by Claude Code