Repository navigation
fix(pipeline): subscribe to TaskSettled (not TaskResolved) - #63
Merged
Merged
Conversation
CairnCore never emits TaskResolved (the pipeline's event filter would never fire). It emits TaskSettled(taskId, resolutionType, primaryPayout, fallbackPayout, protocolFee) on every settlement path. Subscribe to TaskSettled and enrich the agent addresses + checkpoint counts (which TaskSettled doesn't carry) from getTask(taskId), best-effort. Updated docstrings/README event references; kept the adapter's on_task_resolved semantic name and Bonfires episode labels. Co-Authored-By: Lagartha <ionanova22@gmail.com>
MarouaBoud
added a commit
that referenced
this pull request
Sep 1, 2026
… open item (#64) Co-authored-by: Lagartha <ionanova22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last consistency item from the external review's ABI/events finding.
CairnCore never emits
TaskResolved, so the pipeline's event filter would never fire. It emitsTaskSettled(taskId, resolutionType, primaryPayout, fallbackPayout, protocolFee)on every settlement path (success / dispute ruling / timeout refund). The listener now subscribes toTaskSettledand enriches the agent addresses + checkpoint counts (not carried by the event) fromgetTask(taskId), best-effort. Docstrings/README updated; the address was already fixed in #60.py_compileclean.