Repository navigation
Add demo mission requirements - #24
Merged
Merged
Conversation
The demo mission's processing image is built by the build_demo_sdc_aws_processing_lambda CodeBuild project in swxsoc/sdc_aws_architecture, whose buildspec selects lambda_function/<mission>-requirements.txt and exits when it is missing. Pin the single demo instrument package, demo_craft, at v0.0.1 alongside swxsoc and psycopg2-binary, list it in the dev requirements for unit testing, and record the file in AGENTS.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the dependency and documentation changes.
No open issues 🎉
What changed in this PR
Adds the dependency file needed for the existing mission-based build pipeline to build the demo mission’s processing Lambda image. Runtime instrument resolution remains a separate swxsoc configuration follow-up.
Changes:
- Adds demo image dependencies, including
demo_craftpinned tov0.0.1. - Adds the same instrument package pin to development requirements.
- Documents the new requirements file in the repository structure.
| File | Description |
|---|---|
requirements.dev.txt |
Adds the pinned demo instrument package for development. |
lambda_function/demo-requirements.txt |
Defines dependencies for the demo Lambda image. |
AGENTS.md |
Lists the demo requirements file in the directory tree. |
Review effort: Balanced
jamesray
added a commit
to swxsoc/sdc_aws_architecture
that referenced
this pull request
Nov 12, 2026
swxsoc/sdc_aws_processing_lambda#24 added lambda_function/demo-requirements.txt on 2026-11-09, so the root README no longer lists it as a step to take. The base image buildspec and swxsoc demo configuration changes are still open. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
lambda_function/demo-requirements.txtso the processing Lambda image for the new demo mission can be built.The demo mission's image is built by the
build_demo_sdc_aws_processing_lambdaCodeBuild project defined inswxsoc/sdc_aws_architecture(swxsoc/sdc_aws_architecture#55).buildspec.ymlderives the mission from the project name, selectslambda_function/<mission>-requirements.txt, and exits when that file is missing, so the demo image cannot build until this file exists.The file follows
swxsoc_pipeline-requirements.txt:psycopg2-binaryswxsocandswxsoc[tracker]fromgit+https://github.com/swxsoc/swxsoc.git@maindemo_craft @ git+https://github.com/swxsoc/demo_craft.git@v0.0.1— the demo mission's single instrument package. It depends only on astropy, numpy and swxsoc, and reads and writes CSV, so no CDF library is needed.Also:
requirements.dev.txtgains a# Demoblock with the samedemo_craftpin, matching how the other missions' instrument packages are listed for unit testing.AGENTS.mdlists the new requirements file in thelambda_function/tree.Mission enumeration
Nothing in this repository enumerates missions centrally:
buildspec.ymlderives the mission from the CodeBuild project name,calibration.ymlis hard-coded to padre, andtest_processor.pyparametrizes individual instrument test files. No demo test case is added because swxsoc'sdemomission config does not yet listcraft(it still carries the templateMyInstrument1/MyInstrument2), soget_instrument_package("craft")cannot resolve underSWXSOC_MISSION=demo; that is a swxsoc config follow-up.Verification
pip install -r lambda_function/demo-requirements.txtsucceeds in a clean Python 3.12 venv, anddemo_craft.calibration.process_fileimports the way the Lambda does at runtime.requirements.dev.txtinstalled on top,ruff check/ruff format --checkpass andpytest lambda_function/testspasses all 10 tests locally.🤖 Generated with Claude Code