Repository navigation
Fix HTML validation errors in the templates - #205
Open
ArneshBanerjee wants to merge 1 commit into
Open
ArneshBanerjee wants to merge 1 commit into
ArneshBanerjee wants to merge 1 commit into
Conversation
The generated pages reported errors on the W3C validator: - base.html: a stray quote in the Online Shell nav item, an unclosed "Follow Us" heading, and an unescaped "|" in the Google Fonts URL - features.html: nine stray "</>" end tags in the cryptography list - support.html, development.html, roadmap.html: lists wrapped in <p> - download.html, shell.html: <pre> wrapped in <p> - donate.html: unclosed <section id="get-started"> - roadmap.html: <h1> closed with </h2> - development.html, roadmap.html: sidebar card reused id="about" - shell.html: empty iframe src and non-integer width/height - index.html: unescaped "&" in a link features.html also had "</a>" inside a translatable string, and the Dutch translation dropped it, which left the link open on the Dutch page. The tag now sits in the template. All 81 generated pages now parse with no errors. Fixes sympy#42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Ran the generated pages through the Nu HTML validator. The errors were:
base.html: a stray quote in the Online Shell nav item, an unclosed "Follow Us" heading, and an unescaped|in the Google Fonts URLfeatures.html: nine stray</>end tags in the cryptography listsupport.html,development.html,roadmap.html: lists wrapped in<p>download.html,shell.html:<pre>wrapped in<p>donate.html: unclosed<section id="get-started">roadmap.html:<h1>closed with</h2>development.html,roadmap.html: the sidebar card reusedid="about", whichbase.htmlalready usesshell.html: empty iframesrc, andwidth/heightthat are not integersindex.html: unescaped&in a linkfeatures.htmlalso had</a>inside a translatable string. The Dutch translation dropped it, so the link stayed open on the Dutch features page. The tag now sits in the template, and "Polynomials" on its own is already translated in every catalogue that had it.All 81 generated pages now validate with no errors.
Two notes on the translations:
roadmap.html, which had a whole<ul>inside the translatable string. It is now a real list with the items translated separately. Spanish was the only language that had it translated, so I moved that text over ines.poand recompiledes.mo.One thing to flag: the README says styling changes belong in sympy-web-static. The
shell.htmlfix adds a small<style>block, because the iframe sizing was inwidth/heightattributes that are not valid HTML. I kept it in the template so the fix is self-contained, but happy to move it tobase.cssin sympy-web-static and bump the submodule instead if you prefer.