metrics: op=pin writes the flag the prompt reads - #35
Merged
Merged
Conversation
`_queries_block()` reads `pinned` on a `metric_queries` row and nothing
wrote it: `write_schema op=extend` saves a row's schema alone. The tool
gains `op=pin {name, pinned}`: one UpdateItem on the row, a canonical
name copied in first so a pin never needs a prior call, 404 on an
unknown name, 400 on a non-boolean. The manage role gains UpdateItem on
the schema table. modules/agent's AGENTS names the block in the dynamic
tail, which the #30 build left out.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gap the tmp/057 coverage audit found: the prompt's dynamic tail reads
pinnedon ametric_queriesrow and no op set it.manage_metrics op=pin {name, pinned}: one UpdateItem on the row; a canonical name is copied in first, so a pin never needs a priorquery; 404 on an unknown name, 400 on a non-booleanpinneddynamodb:UpdateItemon the schema table (per_customer shape change)_queries_block()in the dynamic tailbash scripts/test.sh --module metrics: 18 passed across 3 files