Repository navigation
Conversation
I don't know for *sure* this is a cryptography disaster, but I remember stubbing it out this way, and remember having some misgivings, and remember wondering if this sort of thing is a failure mode of being a solo dev on a project. Anyway, this will break compatibility with v4, but is *clearly* an improvement imo (and not even that much code 🙃 )
sz3
commented
Jan 9, 2026
| out[i] ^= in[i]; | ||
| // out = hmac(out + in) | ||
| // hmac key is our nonce | ||
| crypto_generichash_state hashState; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is why they say "don't write cryptography" I suppose (though in this case it's more like "you need someone to remind you to replace the stubbed out xor impl with a real one" 🙃 )
Only effects the hybrid
mcleece_crypto_box_seal()and unseal, and is only a theoretical vulnerability afaik. But obviously: it's bad, anyone who used the old version should switch, etc etc. You probably know the drill if you're using experimental cryptography projects like this. 🙂(as an aside, I'm strongly considering archiving this project. https://github.com/open-quantum-safe/liboqs and other post-quantum crypto libraries have come a long way since mid-2020, and the general lack of PQ crypto libraries back then was the primary motivation for me in throwing this together.)