Repository navigation
go.mod: include Tailscale netstack close fix - #161
Merged
bradfitz merged 1 commit intoNov 5, 2026
Merged
Conversation
Member
|
Looks like Nix failed on CI. |
The newer tailscale.com requires Go 1.27.2. nixpkgs-unstable now ships go_1_27 = 1.27.3, so drop flake.nix's Go 1.27.1 source-build override, use buildGo127Module, and update the nixpkgs pin.
bradfitz
force-pushed
the
fix/tailscale-netstack-close-21631
branch
from
November 5, 2026 14:28
698730c to
610b83e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #151 reproduces
Server.Closehanging when the netstack's outbound reset queue fills. Upstream fixed that deadlock in tailscale/tailscale#21668, merged asfb79793, but Tailcat's pinnedtailscale.comrevision predates the fix.Upgrade
tailscale.comto the merged revision and synchronize the Go minimum, transitive modules, Nix hashes, and release-tag manifests. This change addresses the reported netstack close deadlock; the separate TCP option and abortive-close requests in #151 are outside this patch.Checks
go build ./...go test -count=1 -timeout 600s ./...(Windows; Git Bash added to PATH for the Unix-shell test)go vet ./...go mod tidygo run ./tool/updateflakes