Skip to content

go.mod: include Tailscale netstack close fix - #161

Merged
bradfitz merged 1 commit into
tailscale:mainfrom
dajiaohuang:fix/tailscale-netstack-close-21631
Nov 5, 2026
Merged

bradfitz merged 1 commit into
tailscale:mainfrom
dajiaohuang:fix/tailscale-netstack-close-21631

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

Issue #151 reproduces Server.Close hanging when the netstack's outbound reset queue fills. Upstream fixed that deadlock in tailscale/tailscale#21668, merged as fb79793, but Tailcat's pinned tailscale.com revision predates the fix.

Upgrade tailscale.com to the merged revision and synchronize the Go minimum, transitive modules, Nix hashes, and release-tag manifests. This change addresses the reported netstack close deadlock; the separate TCP option and abortive-close requests in #151 are outside this patch.

Checks

  • go build ./...
  • go test -count=1 -timeout 600s ./... (Windows; Git Bash added to PATH for the Unix-shell test)
  • go vet ./...
  • go mod tidy
  • go run ./tool/updateflakes

@bradfitz

bradfitz commented Nov 5, 2026

Copy link
Copy Markdown
Member

Looks like Nix failed on CI.

The newer tailscale.com requires Go 1.27.2. nixpkgs-unstable now
ships go_1_27 = 1.27.3, so drop flake.nix's Go 1.27.1 source-build
override, use buildGo127Module, and update the nixpkgs pin.
@bradfitz
bradfitz force-pushed the fix/tailscale-netstack-close-21631 branch from 698730c to 610b83e Compare November 5, 2026 14:28
@bradfitz
bradfitz merged commit e00cdde into tailscale:main Nov 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants