Repository navigation
[feat] Implement PHP doQuotes logic - #432
Merged
Merged
Conversation
kristian-clausal
requested changes
Sep 16, 2026
Contributor
Author
|
Let me know if the wording of the comment suits you o/ |
kristian-clausal
approved these changes
Sep 18, 2026
kristian-clausal
left a comment
kristian-clausal
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
Collaborator
|
Thank you for the commit! |
kristian-clausal
added a commit
to tatuylonen/wiktextract
that referenced
this pull request
Sep 18, 2026
See wikitextprocessor tatuylonen/wikitextprocessor#432 Changes to how we parsed `'` tokens caused this test to fail because the "bold" and the apostrophe next to it moved places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convoluted because their logic is (and tbh, rightfully so). The myriad of tests and references to the original PHP code should be good enough (they don't even cover all of the edge cases of their implementation, so I didn't try it either!)
See tatuylonen/wiktextract#1706
The test I added in tatuylonen/wiktextract#1707 should pass when this lands, and we will have validation then to close that issue.
For full transparency, the code was LLM generated and only marginally tweaked by hand. I did check the implementation a couple times and really nudged it to simplify much of the initial boilerplate/noisy LLM output we all know and love.