Repository navigation
feat(fix-perms): add OnRootMismatch change policy - #6
Merged
Merged
Conversation
Add the FIX_PERMS_POLICY environment variable, mirroring Kubernetes' fsGroupChangePolicy. With OnRootMismatch, a spec path is skipped entirely when its root already has the expected owner and mode, avoiding a full traversal of large trees. Always (default) keeps the current behaviour. Invalid values warn and fall back to Always.
amannocci
force-pushed
the
feat/on-root-mismatch
branch
from
October 24, 2026 13:27
8bc2314 to
3593504
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FIX_PERMS_POLICYenv var that works like Kubernetes'fsGroupChangePolicy. Values areAlways(default) andOnRootMismatch, case-insensitive.OnRootMismatch, a spec path is skipped entirely when its root already has the expected uid:gid and mode, so large trees are not walked on every start. The skip is logged on stderr.Always, so no fix is ever skipped by mistake.check_entryhelper, used by both the root check and the per-entry walk.USERMAP_UID,USERMAP_GIDandFIX_PERMS_POLICY.Test plan
cargo fmt,cargo clippy -D warnings,cargo test -p fix-permspass locally (19 tests, 5 new).