Skip to content

fix: make install robust under umask 077 (test + MTProxy binary perms) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bip-bup-bip-bup wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −0
Open

fix: make install robust under umask 077 (test + MTProxy binary perms) #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
401a585
test: make credential permission test umask-independent
bip-bup-bip-bup Aug 27, 2026
217ba25
fix: make MTProxy build tree usable by the mtproxy service user
bip-bup-bip-bup Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions deploy/install-mtproxy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ if [[ ! -x "$source_directory/objs/bin/mtproto-proxy" ]] ||
rm -rf "$temporary"
fi

# install.sh runs with umask 077, so make's output keeps owner-only
# permissions; the unprivileged mtproxy service user must be able to
# traverse the tree and execute the binary. Normalize permissions
# unconditionally: when the guard above skipped a rebuild (a previous
# failed run may already have left /opt/MTProxy with a root-owned
# 0700 binary), the tree is reused as-is and still needs this fix.
chown -R root:root "$source_directory"
chmod -R a+rX "$source_directory"

install -d -o root -g mtproxy -m 0750 /etc/mtproxy
secret_temp="$(mktemp /etc/mtproxy/proxy-secret.XXXXXX)"
config_temp="$(mktemp /etc/mtproxy/proxy-multi.conf.XXXXXX)"
Expand Down
6 changes: 6 additions & 0 deletions internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,12 @@ func TestLoadAcceptsSystemdCredentialReadPermissions(t *testing.T) {
if err := os.WriteFile(profiles, []byte(content), 0444); err != nil {
t.Fatal(err)
}
// Force the intended mode: install.sh runs tests under umask 077,
// which would otherwise strip the group/other read bits and make the
// "outside a credential directory" assertion below vacuously pass.
if err := os.Chmod(profiles, 0444); err != nil {
t.Fatal(err)
}
t.Setenv("CREDENTIALS_DIRECTORY", credentials)
server := `{"public_hostname":"proxy.example.com","public_dir":"public","profiles_file":"credentials/profiles.json"}`
path := filepath.Join(directory, "config.json")
Expand Down