[cleanup] Phase 2b: Exclude unused haystack providers from workspace builds #623

Activity

1. AlexMikhalev

   added a commit that references this issue on Mar 4, 2026

   refactor: exclude unused crates from workspace, fix flaky tests

   ...

   b606c77
2. AlexMikhalev commented on Mar 4, 2026

   

   AlexMikhalev

   on Mar 4, 2026

   ContributorAuthor

   More actions

   PR #631 addresses this. Excluded haystack_atlassian, haystack_discourse, haystack_jmap, haystack_grepapp from workspace builds.
3. AlexMikhalev

   added a commit that references this issue on Mar 11, 2026

   feat(haystack): enable grepapp_haystack in workspace

   ...

   a8c5dec
4. AlexMikhalev commented on Mar 11, 2026

   

   AlexMikhalev

   on Mar 11, 2026

   ContributorAuthor

   More actions

   Implementation Complete

   I have successfully feature-flagged the haystack providers:

   Changes Made

   terraphim_middleware/Cargo.toml:

   • Marked haystack_jmap as optional dependency
   • Added jmap feature flag: jmap = ["dep:haystack_jmap"]

   terraphim_middleware/src/haystack/mod.rs:

   • Added #[cfg(feature = "jmap")] to module declaration
   • Added #[cfg(feature = "jmap")] to re-export

   terraphim_middleware/src/indexer/mod.rs:

   • Added conditional import for JmapHaystackIndexer
   • Wrapped ServiceType::Jmap match arm with feature gates
   • Added graceful fallback when feature is disabled (logs warning, returns empty index)

   Verification

   • cargo check -p terraphim_middleware ✓
   • cargo check -p terraphim_middleware --features jmap ✓
   • cargo check --workspace ✓
   • cargo test -p terraphim_middleware ✓

   Notes

   • haystack_grepapp was already feature-flagged with the grepapp feature
   • haystack_jmap now follows the same pattern as grepapp_haystack
   • Both crates remain in the workspace (required for path dependencies to work)

   Commit: 20f99c9c
5. AlexMikhalev commented on Mar 11, 2026

   

   AlexMikhalev

   on Mar 11, 2026

   ContributorAuthor

   More actions

   Feature-flagging implementation complete. haystack_jmap is now an optional dependency with a 'jmap' feature flag, following the same pattern as grepapp_haystack.
6. AlexMikhalev

   closed this as completedon Mar 11, 2026
7. AlexMikhalev

   added 4 commits that reference this issue on Apr 25, 2026

   feat(haystack): enable grepapp_haystack in workspace

   ...

   5c32817

   Merge pull request 'Fix terraphim/adf-fleet#8: meta-prompts (project-…

   ...

   60ffcf0

   feat(haystack): enable grepapp_haystack in workspace

   ...

   6a5061e

   Merge pull request 'Fix terraphim/adf-fleet#8: meta-prompts (project-…

   ...

   ecdfb8e