Repository navigation
fix: resolve GitHub Actions CI failures across platforms - #332
Merged
Merged
Conversation
5 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else | ||
| source .venv/bin/activate | ||
| fi | ||
| maturin develop --target native |
There was a problem hiding this comment.
maturin develop --target native passes an invalid Rust target triple; cargo does not recognize a target named native, so this step will fail on every runner before building the bindings (the default host target is already used when --target is omitted). The same flag is used again in the release build later in the workflow, so both steps will break CI until the target override is removed or replaced with a real triple.
Useful? React with 👍 / 👎.
AlexMikhalev
added a commit
that referenced
this pull request
Apr 5, 2026
…332 - Add set_quickwit_sink() and quickwit_config() public methods to AgentOrchestrator - Log agent spawn (INFO) in spawn_agent() via sink.send() - Log agent exit (INFO/WARN by exit code) in poll_agent_exits() with wall_time_secs - Log stdout/stderr lines in drain_output_events() via sink.try_send() (sync ctx) - Init QuickwitSink from orchestrator config in bin/adf.rs startup Co-Authored-By: Terraphim AI <noreply@terraphim.ai>
AlexMikhalev
added a commit
that referenced
this pull request
Apr 5, 2026
AlexMikhalev
added a commit
that referenced
this pull request
Apr 5, 2026
…332 - Add set_quickwit_sink() and quickwit_config() public methods to AgentOrchestrator - Log agent spawn (INFO) in spawn_agent() via sink.send() - Log agent exit (INFO/WARN by exit code) in poll_agent_exits() with wall_time_secs - Log stdout/stderr lines in drain_output_events() via sink.try_send() (sync ctx) - Init QuickwitSink from orchestrator config in bin/adf.rs startup Co-Authored-By: Terraphim AI <noreply@terraphim.ai>
AlexMikhalev
added a commit
that referenced
this pull request
Apr 5, 2026
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
…332 - Add set_quickwit_sink() and quickwit_config() public methods to AgentOrchestrator - Log agent spawn (INFO) in spawn_agent() via sink.send() - Log agent exit (INFO/WARN by exit code) in poll_agent_exits() with wall_time_secs - Log stdout/stderr lines in drain_output_events() via sink.try_send() (sync ctx) - Init QuickwitSink from orchestrator config in bin/adf.rs startup Co-Authored-By: Terraphim AI <noreply@terraphim.ai>
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
AlexMikhalev
added a commit
that referenced
this pull request
May 1, 2026
…332 - Add set_quickwit_sink() and quickwit_config() public methods to AgentOrchestrator - Log agent spawn (INFO) in spawn_agent() via sink.send() - Log agent exit (INFO/WARN by exit code) in poll_agent_exits() with wall_time_secs - Log stdout/stderr lines in drain_output_events() via sink.try_send() (sync ctx) - Init QuickwitSink from orchestrator config in bin/adf.rs startup Co-Authored-By: Terraphim AI <noreply@terraphim.ai>
AlexMikhalev
added a commit
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiple GitHub Actions CI failures across all platforms:
🐛 Issues Fixed
Ruff Import Sorting Errors
Windows Virtual Environment Setup
.venv/Scripts/activate)macOS Cross-compilation Errors
--target nativeto maturin buildsConda Environment Conflicts
CONDA_PREFIXbefore creating virtual environments🔧 Technical Changes
ruff check --fix--target nativeto prevent cross-compilationshell: bashfor consistent behavior🎯 Impact
These changes should resolve all current CI failures:
🧪 Testing
The fixes address root causes identified in recent CI runs:
Fixes issues in: #328, #289