Add GitHub Actions workflow for automated minimal release

[AlexMikhalev]

Summary

• Add GitHub Actions workflow for automated minimal release
• Add comprehensive documentation for cross-platform installation
• Add platform verification report and system requirements
• Update Homebrew formulas and publication scripts

Changes

• Created .github/workflows/release-minimal.yml for automated binary releases
• Added comprehensive README for the release workflow
• Updated cross-platform installation documentation
• Added platform verification and memory usage reports
• Updated Homebrew formulas with correct checksums
• Created publication scripts for automated releases

Testing

• Verified workflow syntax and configuration
• Tested platform compatibility matrix
• Validated Homebrew formula updates
• Confirmed publication scripts work correctly

This PR enables automated releases for terraphim-repl and terraphim-cli binaries across multiple platforms.

[claude]

Code Review: Minimal Release Workflow

This PR adds substantial infrastructure for automated releases of terraphim-repl and terraphim-cli. Overall, this is well-structured work, but there are several important issues to address before merging.

---

Critical Issues

1. Missing Tests for New Binaries

The two new binary crates (terraphim-cli and terraphim-repl) have NO tests. According to CLAUDE.md guidelines:

• "Never use mocks in tests"
• "Always check test coverage after implementation"

Action Required:

• Add integration tests for both crates
• Test command execution and output formats
• Verify offline mode functionality
• Test JSON output parsing

2. GitHub Actions Workflow Issues

Issue 2a: Shell Syntax Error (Lines 71-73, 76-79)

The workflow uses GitHub Actions expressions inside shell scripts which will not work:

${{ matrix.use_cross && 'cross' || 'cargo' }} build --release

This will literally try to execute a command starting with "${{" which is invalid.

Fix: Use environment variables or conditional steps instead.

Issue 2b: Homebrew Formula Update Logic (Line 273)

git push origin HEAD:${{ github.ref_name }}

Problem: When triggered by a tag push, github.ref_name is the tag name (e.g., v1.0.0), not a branch. You cannot push commits to a tag.

Fix: Push to main branch instead: git push origin HEAD:main

3. Cargo.toml Edition Incompatibility

Both new crates use edition = "2024" but Rust edition 2024 does not exist yet. Current editions are 2015, 2018, and 2021.

Fix: Change to edition = "2021" in both Cargo.toml files.

4. Binary Size Optimization Concerns

Using opt-level = "z" and strip = true is very aggressive and can break async Rust code or make debugging impossible.

Recommendation: Test thoroughly or use opt-level = 3 or opt-level = "s" instead.

---

Major Issues

5. Pre-commit Hooks Not Run

CLAUDE.md requires pre-commit checks before commit. This PR adds 10,000+ lines without evidence of validation.

Action: Run ./scripts/install-hooks.sh and verify all checks pass.

6. Incomplete crates.io Publishing Strategy

The binaries depend on terraphim_service, terraphim_config, etc. which are NOT being published to crates.io. Only terraphim_types, terraphim_automata, and terraphim_rolegraph are mentioned.

Problem: Users cannot compile these binaries via cargo install because dependencies are missing.

Fix: Either publish all dependencies OR only distribute pre-built binaries.

7. Embedded Assets Not Validated

terraphim-repl embeds assets from assets/ directory but no verification that these files exist or are valid. The files (default_config.json, default_thesaurus.json) are not visible in this PR.

Action: Verify embedded assets exist and include them in review.

8. Error Handling Mixes stdout/stderr

In terraphim-cli/src/main.rs:260-262, error messages go to stdout instead of stderr.

Fix: Use eprintln!() for error output.

---

Minor Issues

9. Documentation describes 3-week plan but PR implements everything at once
10. No MSRV specified in Cargo.toml
11. Cross compilation installs from git instead of tagged version
12. Script requires 1Password CLI but workflow does not use the script
13. Missing changelog entries for new binary crates

---

Positive Aspects

1. Well-structured workflow with proper job dependencies
2. Multi-platform support covering all major platforms
3. Automatic Homebrew formula updates - excellent automation
4. Proper checksum generation for security
5. Clean separation between REPL and CLI tools
6. Good use of rust-embed for offline capability
7. Comprehensive documentation

---

Recommendations Before Merging

MUST FIX:

1. Fix critical workflow syntax errors
2. Change edition from 2024 to 2021
3. Add integration tests for both binaries
4. Verify embedded assets exist
5. Fix Homebrew push logic
6. Clarify crates.io publishing strategy
7. Run pre-commit hooks

NICE TO HAVE:

• Add CI job that builds/tests these binaries
• Document MSRV clearly
• Add --help output examples
• Test on each platform before release

---

Final Verdict

Status: NEEDS WORK - Several critical issues must be fixed before merging.

Estimated effort to fix: 2-4 hours for critical issues, plus time for tests.

This is solid infrastructure work with good automation patterns, but the workflow syntax errors and missing tests are blockers. Once fixed, this will be a valuable addition to the project.