Repository navigation
fix(automata): correct URL validation in AutomataPath::from_remote() - #733
Merged
Merged
Conversation
…ote() The condition used `||` (OR) instead of `&&` (AND), causing De Morgan's law to make the check always evaluate to true -- rejecting all URLs including valid http:// and https:// ones. Also adds scheme-specific prefixes (http:// and https://) instead of bare "http"/"https". Fixes #139 Co-Authored-By: Terraphim AI <noreply@anthropic.com>
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
…ote() (#733) The condition used `||` (OR) instead of `&&` (AND), causing De Morgan's law to make the check always evaluate to true -- rejecting all URLs including valid http:// and https:// ones. Also adds scheme-specific prefixes (http:// and https://) instead of bare "http"/"https". Fixes #139 Co-authored-by: Terraphim AI <noreply@anthropic.com>
AlexMikhalev
added a commit
that referenced
this pull request
May 1, 2026
…ote() (#733) The condition used `||` (OR) instead of `&&` (AND), causing De Morgan's law to make the check always evaluate to true -- rejecting all URLs including valid http:// and https:// ones. Also adds scheme-specific prefixes (http:// and https://) instead of bare "http"/"https". Fixes #139 Co-authored-by: Terraphim AI <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutomataPath::from_remote()URL validation:!a || !b(always true) changed to!a && !bhttp://,https://) instead of barehttp/httpsImpact
Remote thesaurus loading was completely broken -- all URLs were rejected by the validator.
Fixes #139
Test plan
cargo test -p terraphim_automata test_from_remote-- 5/5 passcargo test -p terraphim_automata-- all 50 tests passcargo clippy -p terraphim_automata-- cleancargo fmt-- cleanGenerated with Terraphim AI