Repository navigation
fix: Docker build and crates.io publishing for v1.16.33 release - #803
Merged
Merged
Conversation
- Dockerfile.multiarch: replace stale partial crate copy with proper workspace COPY directives (crates/, terraphim_server, terraphim_ai_nodejs, terraphim_firecracker/Cargo.toml) - Dockerfile.multiarch: update default RUST_VERSION from 1.85.0 to 1.92.0 - .dockerignore: allow terraphim_firecracker/Cargo.toml through - Move review types (FindingSeverity, FindingCategory, ReviewFinding, ReviewAgentOutput, deduplicate_findings) from terraphim_symphony to terraphim_types, removing terraphim_symphony dependency from terraphim_orchestrator (fixes crates.io publish: symphony is excluded from workspace) - Add terraphim_tracker and terraphim_orchestrator to publish-crates.sh CRATES array in correct dependency order
AlexMikhalev
force-pushed
the
fix/docker-and-publish
branch
from
April 14, 2026 08:47
1d0a00d to
492f87e
Compare
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
fix: Docker build and crates.io publishing for v1.16.33 release
AlexMikhalev
added a commit
that referenced
this pull request
May 1, 2026
fix: Docker build and crates.io publishing for v1.16.33 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Causes
Dockerfile.multiarchhad stale partial-copy logic that missed workspace members. CI passedRUST_VERSION=1.92.0as build-arg but the default1.85.0was too old for current deps.terraphim_agentdepends onterraphim_orchestratorwhich depended onterraphim_symphony(excluded from workspace). Only 4 items from symphony were actually used (FindingSeverity, FindingCategory, ReviewFinding, deduplicate_findings) - moved to terraphim_types.Test Plan
cargo build --workspacepassescargo test -p terraphim_orchestratorpasses (10 tests)cargo test -p terraphim_typespasses (15 tests)cargo clippycleandocker buildx build --platform linux/amd64 -f docker/Dockerfile.multiarch --target rust-builder --build-arg RUST_VERSION=1.92.0 .- all 3 binaries built and version-verified