Repository navigation
feat: release public LSP packages and apply authored synonyms in stock Zed - #976
Merged
Merged
Conversation
Contributor
Documentation PreviewYour documentation changes have been deployed to: This preview will be available until the PR is closed. |
Contributor
Documentation PreviewYour documentation changes have been deployed to: This preview will be available until the PR is closed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public language server still used the older implementation and private dependency graph, preventing a reproducible public release of saved alternatives and synonym export. This imports the existing LSP/shared analysis core into a standalone public workspace, using the now-published Terraphim types, parser, automata, Alternatives and Lab packages.
Stock Zed's generic LSP command picker displays a returned
WorkspaceEditwithout applying it. The new explicitterraphim.alternative.add_and_applycommand requests one versioned client edit and acknowledges success only after observing the expected document change. The originalalternative.addAPI is preserved. Rejected edits, timeouts, stale versions, concurrent changes and document reopen are explicit outcomes; a late change is handled without issuing a second edit.Release automation qualifies an exact package tag from public
main, tests the extracted core package, and compares the downloaded crates.io archive with the qualified bytes. Existing crate names use trusted publishing; the new core name has a separate explicit first-publication bootstrap path. Only successful server-crate readback can call the six-target binary publisher, which retains immutable asset/resume rules and saves real protocol outputs for native lanes. Legacy publishing paths reject these reserved package names before credentials, while bundled server releases retain their existing LSP artifact paths.Validation:
cargo packageand tests from its extracted archive passed; server package contents were inspected. Final server package verification follows publication of core 1.23.1 through this workflow.The public versions are core 1.23.1 and server 1.22.0-rc.4. The source PR does not itself publish a crate or binary. macOS release binaries are unsigned, and cross-target artifacts explicitly retain their runtime-validation limits.