Skip to content

fix: correct Cross build directory for LSP RC5 - #977

Merged
AlexMikhalev merged 2 commits into
mainfrom
codex/fix-lsp-cross-build-directory
Oct 14, 2026
Merged

AlexMikhalev merged 2 commits into
mainfrom
codex/fix-lsp-cross-build-directory

Conversation

@AlexMikhalev

Copy link
Copy Markdown
Contributor

RC4's musl lanes failed before compilation because the pinned Cross wrapper forwarded the host's absolute CARGO_BUILD_BUILD_DIR into a container where only CARGO_TARGET_DIR was remapped to /target. Omit the redundant build-directory override only for Cross subprocesses, preserving native command environments and filesystem permissions.

Advance only the server manifest, lock and release allowlist to 1.22.0-rc.5 for a new immutable release. Core remains 1.23.1; the published RC4 crate and tag stay unchanged. No LSP runtime implementation changes.

Validation:

  • Reproduced the original permission error and corrected compile/run with real non-root, network-disabled Cargo 1.96 containers.
  • Built the published RC4 crate with the corrected helper and exact pinned Cross revision for both x86-64 and ARM64 musl. The x86-64 binary passed version and actual save/reopen/synonym-export checks; ARM64 was architecture-checked without a runtime claim. These diagnostic outputs were not published.
  • 123 Python release/guard tests; 262 native server tests and three benchmark smokes; strict Clippy, formatting and clean public manifest/lock validation.
  • RC5 package built and verified against published crates.io dependencies. Focused protocol and CLI checks run from the extracted package.

The normal CI/release workflow must qualify and publish RC5 before its binaries are considered released.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation Preview

Your documentation changes have been deployed to:
https://1355a057.terraphim-docs.pages.dev

This preview will be available until the PR is closed.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation Preview

Your documentation changes have been deployed to:
https://04938780.terraphim-docs.pages.dev

This preview will be available until the PR is closed.

@AlexMikhalev
AlexMikhalev merged commit b52ebec into main Oct 14, 2026
9 checks passed
@AlexMikhalev
AlexMikhalev deleted the codex/fix-lsp-cross-build-directory branch October 14, 2026 13:59

This branch was successfully deployed

1 active deployment
docs-preview — 24189425 Deployed Oct 14, 2026 by AlexMikhalev via Deploy Preview #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant