Skip to content

fix: validate producer log names for LSP RC6 - #979

Merged
AlexMikhalev merged 1 commit into
mainfrom
codex/fix-lsp-log-artifact-validation
Oct 14, 2026
Merged

AlexMikhalev merged 1 commit into
mainfrom
codex/fix-lsp-log-artifact-validation

Conversation

@AlexMikhalev

Copy link
Copy Markdown
Contributor

RC5 published its crate and built all six binaries, but final assembly rejected the producer’s own log names such as build-x86_64-unknown-linux-musl.log. The validator now admits only each target’s exact fetch/build log names (and universal.log), retaining hash, command, architecture and saved-output checks.

Prepare server 1.22.0-rc.6 through the existing tag/OIDC pipeline. Runtime Rust and core 1.23.1 are unchanged; previous crates, source tags and CI artifacts remain immutable. The documentation records the separate run-attempt artifact retry limitation.

Validation:

  • 125 release/contract tests pass, including real subprocesses under all 11 producer log names and rejection of traversal, wrong-target and generic names.
  • Five actual RC5 artifact ZIPs verified by immutable ID/digest; all six binaries and their qualification/protocol outputs assemble and pass frozen readback with the correction. The old helper reproduces the original failure. This is local diagnostic assembly, not a published release.
  • 13 actual RC6 CLI/stdio/add-and-apply tests pass, including saved/reopened synonyms. Strict focused Clippy, formatting, Ruff F and public-manifest validation pass.
  • Independent review found no remaining findings; the shared immutable publisher and workflow permissions are unchanged.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation Preview

Your documentation changes have been deployed to:
https://4ef8711c.terraphim-docs.pages.dev

This preview will be available until the PR is closed.

@AlexMikhalev
AlexMikhalev merged commit 264de81 into main Oct 14, 2026
11 checks passed
@AlexMikhalev
AlexMikhalev deleted the codex/fix-lsp-log-artifact-validation branch October 14, 2026 14:34

This branch was successfully deployed

1 active deployment
docs-preview — f4afab9f Deployed Oct 14, 2026 by AlexMikhalev via Deploy Preview #314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant