Repository navigation
fix: verify federated VS Code publisher identity before upload - #980
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marketplace publisher membership needs the federated principal’s Azure DevOps profile ID. The release workflow previously went directly from Azure login to upload, without checking the authenticated client/tenant or exposing that non-secret identity for setup.
Add a fixed metadata check after Azure login. It validates the service-principal client and tenant, queries its own Azure DevOps profile, and preserves only allowlisted non-secret evidence. Publication stops before
vscewhileVSCE_MARKETPLACE_PROFILE_IDis unset or mismatched. After the profile receives Contributor access and the expected ID is configured, rerunning the same release’s marketplace planner promotes its already-qualified VSIX. Authentication failures never fall back to a PAT.Prepare version 0.1.2 because the new step must run from a new immutable version tag; the existing 0.1.1 tag and released bytes remain unchanged. Editor release pins, runtime code and dependency resolutions are unchanged. This uses the existing workflow and tag-protected environment without adding Azure resource permissions or organization membership.
Validation:
git diff --checkpassed.The Entra app and federation have been configured, but actual CI authentication, profile retrieval, publisher Contributor assignment and Marketplace publication remain pending. The normal release pipeline must qualify the new VSIX on all three native hosts and verify the live registry payload. This PR does not claim marketplace availability or qualification of all 41 visual requirements.