Repository navigation
fix(vscode): keep consumed stash shortcut inside editor - #997
Merged
Merged
Conversation
Closes #996. Preserve native Extensions behavior for unhandled keys and gate the packaged Linux UI with actual saved outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Alternative Control consumes Ctrl+Shift+X to stash a selection, VS Code also opens Extensions and takes focus. Stop propagation of only that already-consumed shortcut at the editor container; unhandled keys still reach the workbench. Document/history handling is unchanged.
Adds a pinned development-only Playwright regression to the existing Linux native CI job. It installs the actual VSIX into a fresh profile and exercises rendered controls and real keys. The released 0.1.4 package reproduces the sidebar failure; the candidate passes five cases: stash/focus, immediate native Undo/Redo, empty-selection/native shortcut, plain-mode/native shortcut and ordinary Markdown/native shortcut. Saved input, stash, Undo and Redo files plus screenshots are retained in native-results. This does not qualify other platforms or all 41 requirements.
Validation: 71 asset tests, 20 host protocol/cache tests, 9 export tests, 4 existing link-engine tests; compile, lint, JavaScript syntax, actionlint and whitespace checks pass. The local candidate uses the exact existing released Rust/WASM assets; CI continues to build/verify those assets through its unchanged package job. Vendor runtime/packager warnings and initial harness failures were retained in the evidence packet. No version bump, tag, asset replacement or publishing permission change.
Closes #996