Repository navigation
fix(grep): retrieve content from explicitly selected files - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a single Markdown file with
--paths brief.mdreturned zero passages even when directory search found the authored synonym. The file path is now indexed explicitly through the existing FFF API; neighbouring files are neither scanned nor searched.The pinned FFF version uses the wrong path arena when grep applies constraints to an explicitly added file. Its existing public file-search API safely applies the same parsed constraints first, then the unchanged grep engine handles content. The fix retains filename-hint fallback, query semantics, path guards, file-size limits and the no-mmap budget. Symlink and special-file roots are refused.
Validation: 110 grep tests passed; workspace Clippy with warnings denied, formatting and all-target checks passed. Seven new real CLI tests cover absolute/relative paths, synonyms, Unicode/CRLF, multiple files, filters and neighbour exclusion. Two pre-existing hostile-directory tests cannot run on APFS; the new hostile-filename case is Linux-only and requires CI. Independent review reproduced zero-to-one retrieval against the actual Cursor-saved document and exported graph, with source bytes unchanged.
Gitea issue submission is queued locally because the configured CLI returns401 and the browser is signed out. No issue or public release is claimed by this PR.