Skip to content

Resolve a plan file once and give cross-site scanning one owner - #172

Merged
DavertMik merged 6 commits into
mainfrom
advisor/033-plan-loading-single-resolution
Sep 2, 2026
Merged

Resolve a plan file once and give cross-site scanning one owner#172
DavertMik merged 6 commits into
mainfrom
advisor/033-plan-loading-single-resolution

Conversation

@DavertMik

Copy link
Copy Markdown
Contributor

Plan files passed to explorbot test were resolved and parsed twice with two different search orders (the pre-config peek scanned every registered site; the load scanned the current site's plans dir), so the peek could find one file and the run another. Now the file is resolved once and the peek's result is reused. Plan.resolveFile locates without parsing; plans-command and ExplorBot.loadPlans each parse once.

Cross-site directory scanning ("find X under every registered site's dir") was independently implemented by PR #165 (plan loading) and PR #166 (prima's status); both now go through single owners in global-config.ts (findSiteWith, listSitePlanDirs), and the hardcoded SITE_PLANS_DIR copy in the Plan domain model is gone.

Behavior change: when a plan name resolves to different files in different registered sites, explorbot test <name> now runs the file the pre-config peek found — previously peek and run could disagree.

Testing: bun test tests/unit 1227 pass / 0 fail (2 new Plan.resolveFile tests), bun test boat/prima/tests 135 pass / 0 fail, biome format + lint clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Jz7wTcYsy68jUUjcWttd1B

DavertMik and others added 5 commits September 1, 2026 22:59
…ite directory scanning.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jz7wTcYsy68jUUjcWttd1B
…an file without parsing it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jz7wTcYsy68jUUjcWttd1B
…ts own site scan.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jz7wTcYsy68jUUjcWttd1B
…g in the changelog.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jz7wTcYsy68jUUjcWttd1B
@DavertMik DavertMik added refactoring regression Run the LLM regression suite (one run per label add) labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Explorbot Self-Regression

Commit 134d874 · run

Scenario Result Attempts Duration
basic (native) PASS 1/3 6m
experience: control OK — failed as expected 1/1 34s
experience: seeded PASS 1/3 57s

Attempt details

  • basic (native) attempt 1 — PASS: login evidence: PASS (post-login plan=true, post-login research=true); research: PASS (files=5, wellFormed=true, keywords=7/3); scenarios: PASS (tests=5/5, features=3/3); tests passed: PASS (5 passed, 0 failed (reporter: 5 passed, 0 failed))
  • experience: control attempt 1 — PASS: control: OK — failed as expected (0 passed, 1 failed)
  • experience: seeded attempt 1 — PASS: seeded: PASS (1 passed, 0 failed)

Session analysis — basic (native):

Session Analysis

Issues creation, validation, filtering, search, and detail views produced the expected visible states. Automation was unreliable around modal and filter controls, leaving some assertions incomplete.

Coverage

  • Pages: /issues, /issues?new=1, /issues?label=1, /issues?q=zzzxqv-no-issue-84721&status=, /issues/6
  • Features: Issue creation and persistence, required-field validation, label filtering, empty search results, issue details

What works

  • Issue creation and persistenceET-1 Create a new issue and verify that it is persisted in the issues list.

Execution Issues

  • ET-2 Submit the new issue workflow without required data and verify that the issue is not created. — repeated New Issue clicks; URL assertion unsupported
  • ET-3 Filter the issues list by the visible bug label and verify that the displayed records match the selected label. — modal close clicks failed; active styling unconfirmed
  • ET-4 Search for a term that does not match any issue and verify the no-results state. — Apply filters clicks failed before verification
  • ET-5 Open an issue from the list and verify that its detail view represents the selected issue. — search clearing failed before opening issue

@DavertMik
DavertMik merged commit b4736c1 into main Sep 2, 2026
2 checks passed
@DavertMik
DavertMik deleted the advisor/033-plan-loading-single-resolution branch September 2, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring regression Run the LLM regression suite (one run per label add)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants