Repository navigation
docs: explain secure-storage test limitations - #129
Open
localmojo41 wants to merge 1 commit into
Open
localmojo41 wants to merge 1 commit into
localmojo41 wants to merge 1 commit into
Conversation
Signed-off-by: localmojo41 <15044055+localmojo41@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secure-storage Jest suite uses an in-memory Keychain substitute, so passing tests do not demonstrate native Keychain/Keystore enforcement. This continues the documentation change from #118 against current main for a fresh review.
Document what the mocks cover, which properties still need native validation, and the consuming application's responsibility for device-auth gating. Link the showcase application and #116 for the broader native release gate; this documentation does not close that issue or claim native checks have been performed.
Validation: lint and typecheck pass; all 544 tests pass. The coverage command still fails the configured 80% statement/branch thresholds (79.79% statements, 70.81% branches). Unchanged main also fails those thresholds. No source or test behavior is changed, and this patch does not resolve that existing coverage blocker.