Repository navigation
Run an agent-suggested command as a typed line and remember the ?? turn - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The command an agent hands back from a
??turn ran through a side door: not what was shown, not through the typed-line path, and not linked to the question that produced it. One ordinary turn on HEAD showed all three:The agent replied with the command in backticks; the display stripped them but the executor got a command substitution. The failure then left stale error context, so the bare
??explained a failure ofecho hellothat never happened. History held three unrelated rows and the agent-interactions table had never been written.What changes
??, and an agent-returnedexitends the shell.??turn is recorded inagent_interactions, linked to the history id of the command it produced. A command reply counts as accepted only once a command ran.After the change, the same turn reads:
Verification
go test ./...,go vet ./...andgolangci-lint run ./...are clean at the tip.??explains the right command, Ctrl+R shows the question under the command,echo a??bfrom the agent runs as shell, andecho x&>i statusoffersecho x&&git statusas ghost text.Known limits
gti status || true) shows the accept footer but no ghost, since the learning loop only tracks failures.??path still dispatches the completed line through the??parser (pre-existing).