fix: sync downstream surfaces and automate their regeneration#405
Merged
Conversation
Several surfaces drifted from the recent feature commits (channels `organization` #398, single HTTP client class #402): - Regenerate the stale committed artifacts: playground browser bundle (`website/static/codegen.browser.mjs`), playground config schema (`website/src/schemas/configuration-schema.json`), and the MCP server bundled docs (`mcp-server/lib/resources/bundled-docs.ts`). - Automate their regeneration in `version-bump.yml` via new `generate:playground` and `generate:mcp:docs` scripts, so they refresh in the release PR alongside the existing `generate:assets`. - Teach the MCP server that the `client` generator now supports OpenAPI and the `http` protocol (plus the `clientName` option), replacing the NATS-only protocol filter with a shared mapping helper. - Document the two breaking changes not yet in the migration guide: OpenAPI operation-name cleanup (0.72.3) and native `fetch` in the generated HTTP client (0.72.6). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ALagoni97
approved these changes
Jul 11, 2026
The playground gated the `client` generator to AsyncAPI only and fed the shared protocol selection verbatim to both the `channels` and `client` generators. Since #402 the client generator supports OpenAPI via the `http` protocol, but the picker names it `http_client` (the channels name), so the client config was invalid. - Allow the `client` preset for OpenAPI inputs. - Let the HTTP Client protocol be selected for the client generator. - Map the shared protocol selection onto the client generator's protocol names (`http_client` -> `http`) via a shared `toClientProtocols` helper, in both the JSON-config preview and the generation path. - Make the "client only supports ..." hint input-aware (NATS for AsyncAPI, HTTP for OpenAPI). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
`init` offered OpenAPI as an input type but hard-gated every generator to `inputType === 'asyncapi'`, so choosing OpenAPI produced a config with an empty `generators` array — even when include flags were passed. Since OpenAPI now supports payloads, parameters, headers, channels and the HTTP client (#311, #402), scaffold those for OpenAPI too: - Broaden the flag relationships, interactive prompts and config emission to accept OpenAPI via a shared `supportsGenerators` helper. - Seed OpenAPI-appropriate protocols: `channels` -> `['http_client']`, `client` -> `['http']` (instead of the NATS defaults). - Strengthen init tests to assert the emitted generators (presets and protocols) rather than only that stdout is non-empty, and repurpose the misleading "no AsyncAPI-specific features" test into a real regression guard for OpenAPI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Extend the init command beyond the payloads/parameters/headers/channels/ client presets and AsyncAPI/OpenAPI inputs: - Add `--include-types` and `--include-models` flags (and interactive prompts) for the types and models generators. - Add `jsonschema` as a selectable input type; it exposes only the models generator (the sole preset init offers that supports JSON Schema). - Replace the single asyncapi/openapi gate with a per-preset input-support map so each generator is only offered/emitted for input types it supports (e.g. models works for JSON Schema, types does not). - Re-export `defaultTypeScriptModelsOptions`/`generateTypescriptModels` through the generators barrels so init can consume the models default. - Track types/models in telemetry and .gitignore output paths, and regenerate the command docs. Tests assert the emitted presets per input type, including that JSON Schema drops unsupported presets and keeps only models. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jonaslagoni
changed the title
Contributor
Author
|
🎉 This PR is included in version 0.74.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
While reviewing the commits down to
3e722c5I found several downstream surfaces had drifted from the recent feature commits (channelsorganization#398, single HTTP client class #402, and the OpenAPI HTTP client fixes). The root cause: their generated artifacts aren't wired into any automation, so they only refresh when someone remembers to.Changes
Regenerated the stale committed artifacts (one-time catch-up):
website/static/codegen.browser.mjs— playground engine was last built at fix: generate native fetch HTTP client instead of node-fetch #391, missing fix: forward path-parameter model name for OpenAPI http_client operations #396/feat: add channelsorganizationoption (flat / tag / path) #398/feat: generate a single HTTP client class in the client preset #402.website/src/schemas/configuration-schema.json— playground config schema, missingorganizationandclientName.mcp-server/lib/resources/bundled-docs.ts— MCP bundled docs, last generated at feat: enable channels generator for openapi #311.Automated their regeneration going forward:
generate:playgroundandgenerate:mcp:docsnpm scripts.version-bump.ymlaftergenerate:assets, so all three refresh in thechore(release)PR alongside the schemas/docs that already regenerate there.Fixed MCP server client-protocol drift from #402:
clientgenerator now advertises OpenAPI support, thehttpprotocol, and theclientNameoption.resolveClientProtocolshelper (maps the MCPhttp_clientname → the client generator'shttp).Migration docs:
fetchin the generated HTTP client (0.72.6, fix: generate native fetch HTTP client instead of node-fetch #391).Notes
dist/browser/*build outputs (40 MB bundle + 65 MB map) are gitignored and excluded; only the already-trackedwebsite/static/codegen.browser.mjsis committed.src/(main package) code changed — only npm scripts, a workflow, docs, and the separate mcp-server package — so this is achore:and does not cut a new CLI release.🤖 Generated with Claude Code