Repository navigation
Calculator Code Review - #34
Kunikazu723 wants to merge 1 commit into
Conversation
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
|
@Kunikazu723 Project approved! Apologies for the delay 😄✅ No need to apologize for the structure. Given that you were working from Microsoft’s tutorial, it makes sense that some of the procedural style carried over into the finished project. More importantly, you recognized it yourself, which is always a good thing 😁 Feedback 🔍There is also a mathematical issue with tangent. Currently only exactly 90 degrees is treated as undefined. Tangent is also undefined at 270°, 450°, and so on. 🕵️♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of unused usings, comments and unnecessary empty lines as per picture below. You can read our code conventions here🤓.
☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂 Overall great work!✋🏻Looking forward to seeing your next projects! |


Honestly this was kind of annoying since Microsoft's tutorial is structured in a way that is very procedural programming. It was very difficult to implement new functionality without breaking the code, but I believe that was intended since with this project I learn to appreciate Visual Studio debugging tools a lot more.
I'm really sorry with how the code is structured btw. Personally I would make a project like this with OOP paradigms and Single Responsibility Principle in mind.