Skip to content

Project complete - #40

Closed
AaronjMurphy wants to merge 2 commits into
the-csharp-academy:mainfrom
AaronjMurphy:main
Closed

AaronjMurphy wants to merge 2 commits into
the-csharp-academy:mainfrom
AaronjMurphy:main

Conversation

@AaronjMurphy

Copy link
Copy Markdown

This is a completed version of the Calculator app project. The code from following the tutorial has been altered to allow the completion of challenges.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AaronjMurphy thanks for submitting! At the moment I can't review your project because it doesn't cointain .csproj and .sln project files. Here's a working example:

Image

@AaronjMurphy

Copy link
Copy Markdown
Author

Issues with missing files have been fixed!

@TheCSharpAcademy

Copy link
Copy Markdown

@AaronjMurphy Project approved! 😄✅And well done! You’ve implemented calculation history, history deletion, reuse of previous results, a calculation counter, and several additional mathematical operations. 👏👏

Feedback
🔍️ It's a pretty straight-forward project, so we don't have much to add, as you followed the tutorial correctly and were able to modify the code for the challenges. I hope it gave you a good understanding of a few concepts such as error handling, interacting with the file system, debugging and handling multiple projects under one solution.

🔍The one thing I'd do to make the code more maintainable is replacing List history entries with a small Calculation class containing operands, operation, and result. UseCalculation() currently has to recover the result with Split('=').Last(). Storing structured data would let you simply access something like calculation.Result, which is safer and easier to extend.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants