Skip to content

Console calculator with log files - #44

Closed
Boudiz wants to merge 4 commits into
the-csharp-academy:mainfrom
Boudiz:main
Closed

Boudiz wants to merge 4 commits into
the-csharp-academy:mainfrom
Boudiz:main

Conversation

@Boudiz

@Boudiz Boudiz commented Sep 28, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Boudiz Thanks for submitting. I think something is amiss here. You’ve done a nice job expanding and restructuring the calculator, but an important part of Part 2 of the tutorial is missing.

Image

The tutorial asks you to add a second Class Library project (CalculatorLibrary) to the solution and reference it from the console project. Currently all of your calculator logic is contained within the single CodeReviews.Console.Calculator project. Please revisit Part 2 and implement the second project/class-library portion of the tutorial. Also make sure you complete the later NuGet/JSON logging section.

https://learn.microsoft.com/en-us/visualstudio/get-started/csharp/tutorial-console-part-2?view=vs-2022

💁‍♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.

@TheCSharpAcademy TheCSharpAcademy self-assigned this Sep 28, 2026
@Boudiz

Boudiz commented Sep 28, 2026

Copy link
Copy Markdown
Author

Just added the library and another Logger using Json.
Please feel free to review the changes

@TheCSharpAcademy

Copy link
Copy Markdown

@Boudiz Project approved! 😄✅And well done for completing some of the challenges! 😟 It's always a good use of your time. And nothing stops you from revisiting the project later to complete the other challenges.

Feedback
😍 Very cool use of IParsable for making your checks repeatable. I haven't seen many of these 👏

🔍️ It's a pretty straight-forward project, so we don't have much to add, as you followed the tutorial correctly I hope it gave you a good understanding of a few concepts such as error handling, interacting with the file system, debugging and handling multiple projects under one solution.

🔍One small cleanup: a! - b in subtraction doesn't need the null-forgiving operator because a is a non-nullable double. It can simply be a - b.

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants