Skip to content

Challenges done, ready for review - #47

Closed
PawelNaruszewicz wants to merge 5 commits into
the-csharp-academy:mainfrom
PawelNaruszewicz:main
Closed

PawelNaruszewicz wants to merge 5 commits into
the-csharp-academy:mainfrom
PawelNaruszewicz:main

Conversation

@PawelNaruszewicz

Copy link
Copy Markdown

kinda forgot about this project, came back after some time, but there might still be some mistakes

PawelNaruszewicz and others added 5 commits June 23, 2026 14:57
to do
- separate classes / roles
- add additional features
- split the roles into classes and methods
- added operation logger
- fixed null on input reading
- fixed bug with returning wrong number
@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown

@PawelNaruszewicz Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. Keep in mind that it's a very competitive environment out there in the software development industry. I highly recommend you do everything in your power to stand out from the competition. 👩‍🎤

🥋You still need to submit your Freecodecamp certificate before you start earning belts 😊

Feedback
🔍️ It's a pretty straight-forward project, so we don't have much to add, as you followed the tutorial correctly and refactored the code really well to support the challenges. I hope it gave you a good understanding of a few concepts such as error handling, interacting with the file system, debugging and handling multiple projects under one solution.

🔍️There is some duplication between the two DoOperation() overloads, though. Both select an operation, build an input array, execute it, log it twice, increment the counter, and display the result. You could refactor the shared execution/logging portion into a private method to keep things DRY.

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants