Skip to content

Calculator Code Review - #49

Closed
sonata7245 wants to merge 3 commits into
the-csharp-academy:mainfrom
sonata7245:main
Closed

sonata7245 wants to merge 3 commits into
the-csharp-academy:mainfrom
sonata7245:main

Conversation

@sonata7245

Copy link
Copy Markdown

Created top level menu that allows user to choose what they would like to do, they can perform calculations, view history or see how many times they have used the calculator.

Added logic to store results to a list. The user can use the results from the list as numbers in their next calculations.

Moved methods that related more to the Calculator from main program class to the Calculator class.

Added a Take the Power calculation. In the future could add more calculations but would require a rethink on how the history is being displayed and how numbers are collected as not all functions require 2 numbers, or some may require more.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown

@sonata7245 😄✅ Nice work extending the calculator beyond the basic arithmetic functionality. Keep up the habit of completing the challenges! That's how you learn 👏

Feedback
🔍️ It's a pretty straight-forward project, so we don't have much to add, as you followed the tutorial correctly and were able to modify the code for the challenges. I hope it gave you a good understanding of a few concepts such as error handling, interacting with the file system, debugging and handling multiple projects under one solution.

🕵️‍♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of comments and unused usings, as per picture below. You can read our code conventions here🤓.

image

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants