Skip to content

Finished! - #50

Closed
EternalWanderer7 wants to merge 2 commits into
the-csharp-academy:mainfrom
EternalWanderer7:main
Closed

EternalWanderer7 wants to merge 2 commits into
the-csharp-academy:mainfrom
EternalWanderer7:main

Conversation

@EternalWanderer7

Copy link
Copy Markdown

Really informative project on using JSON to check console output, and a nice review of already learned skills! Please review this critically.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 00:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy self-assigned this Oct 14, 2026

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EternalWanderer7 Thanks for submitting! I can't see this project available for review in the dashboard. Could you please submit in the dashboard before we can approve 😁.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EternalWanderer7 Good work on your Calculator project! There's just one small issue that needs fixing before approval. In Program.cs, you're creating a new Calculator instance inside the loop every time an operation is performed, and then creating another instance to call Finish() when the application exits. Since the constructor creates a new JSON log file, this means previous calculations get overwritten and aren't properly saved.

💁‍♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.

@EternalWanderer7

Copy link
Copy Markdown
Author

Should be fixed now!

@TheCSharpAcademy

Copy link
Copy Markdown

@EternalWanderer7 Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. Keep in mind that it's a very competitive environment out there in the software development industry. I highly recommend you do everything in your power to stand out from the competition. 👩‍🎤

Feedback
🔍️ It's a pretty straight-forward project, so we don't have much to add, as you followed the tutorial correctly I hope it gave you a good understanding of a few concepts such as error handling, interacting with the file system, debugging and handling multiple projects under one solution.

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

🕵️‍♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of unused usings and unnecessary comments, as per picture below. You can read our code conventions here🤓.

image

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants