Repository navigation
Finished! - #50
Finished!#50EternalWanderer7 wants to merge 2 commits into
Conversation
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@EternalWanderer7 Thanks for submitting! I can't see this project available for review in the dashboard. Could you please submit in the dashboard before we can approve 😁.
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@EternalWanderer7 Good work on your Calculator project! There's just one small issue that needs fixing before approval. In Program.cs, you're creating a new Calculator instance inside the loop every time an operation is performed, and then creating another instance to call Finish() when the application exits. Since the constructor creates a new JSON log file, this means previous calculations get overwritten and aren't properly saved.
💁♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.
|
Should be fixed now! |
|
@EternalWanderer7 Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. Keep in mind that it's a very competitive environment out there in the software development industry. I highly recommend you do everything in your power to stand out from the competition. 👩🎤 Feedback 🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP 🕵️♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of unused usings and unnecessary comments, as per picture below. You can read our code conventions here🤓.
☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂 Overall good work!✋🏻Looking forward to seeing your next projects! |

Really informative project on using JSON to check console output, and a nice review of already learned skills! Please review this critically.