Skip to content

project finished - #287

Closed
mikhailkrovikov wants to merge 2 commits into
the-csharp-academy:mainfrom
mikhailkrovikov:main
Closed

mikhailkrovikov wants to merge 2 commits into
the-csharp-academy:mainfrom
mikhailkrovikov:main

Conversation

@mikhailkrovikov

Copy link
Copy Markdown

please review my code tracker, thank you

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikhailkrovikov Thanks for submitting. Before we can approve, could you please fix this bug? It looks like updating a record updates every record at the moment, could you please check? 😊

💁‍♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.

@mikhailkrovikov

Copy link
Copy Markdown
Author

Oups, sorry! Fixed it

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@mikhailkrovikov Project approved! 😄✅ The project is clean and tidy, very easy to use and Spectre makes the UX great. Oh and you completed a bunch of challenges! Well done!

🥋You still need to submit your Freecodecamp certificate before you start earning belts 😊

Feedback
🔍️ Updating a record requires both start time and end time do be updates. Users should be able to update only a single property. Additionally, you could use spectre to let the users choose a record with arrows instead of ids.

🔍️Validation shouldn't be handled by exceptions. Invalid input currently throws an exception, which is caught by the broad catch (Exception ex) in Program.Main, displays the error, and returns the user to the main menu. A validation loop that asks again would be friendlier.

🔍DeleteSessionCommand calculates deletedCount but never uses it, so it would be nice to report something like "3 sessions successfully deleted."

🔍Duration is stored as a string and sorted as a string. With the current fixed HH:mm:ss representation this works for normal same-day durations, but representing duration as a numeric value or TimeSpan would make calculations and future reporting/filtering more robust.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants