Skip to content

Project finished - #288

Closed
RafitaSoler wants to merge 1 commit into
the-csharp-academy:mainfrom
RafitaSoler:main
Closed

RafitaSoler wants to merge 1 commit into
the-csharp-academy:mainfrom
RafitaSoler:main

Conversation

@RafitaSoler

Copy link
Copy Markdown

3 months later...
Ok so I wanted to take a break of like 3 days but as a lazy programmer, that started to become a "why even try" period initiated by bad mentality which got worse over time and lasted almost 3 months. But my mental health is not the point.
I could clearly feel the effects of not coding for so long. I didn't remember many of the things I learned so I had to review for a bit. This also affected the quality of the project but I think for taking a break that long I've made an acceptable work.

Regarding OOP, I started with that many years ago so I'm familiar with it but I find it one of those problems that you never get really good at, I'm always doubting what classes should I create and what they should do. So in the end I've created a few which sort of made sense to me.

As with the previous project I wasn't sure what to test but I decided to at least make a few unit tests , to start getting familiar. I've done a few in jobs before (very very little), and I needed to recall how they work. I'll have them in mind sooner in the development in the future.

Not much more to say, I'll keep going now that I'm motivated again, hoping that it lasts.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy self-assigned this Sep 29, 2026
@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@RafitaSoler Project approved! Glad to have you back😄✅And well done for completing the challenges. You took it to another level. 😎 The UI is smooth and easy to use with Spectre Console and you even included tests. Great work!

🥋And congratulations! You got your Olive Green belt!! 🫒🫒

Feedback
⚠️ No feedback is displayed when the end time is before the start time. The application rejects the value and asks again, but doesn't tell the user what was wrong. A message such as "End time cannot be earlier than start time" would make the validation much clearer.

⚠️ The date format is duplicated. appsettings.json defines DateTimeFormat, but InputValidation hardcodes "yyyy-MM-dd HH:mm:ss". Use the configured value consistently or remove the unused setting.

💡Use an isolated test database. DatabaseManager.EmptyDb() operates against the configured database. A dedicated test database would ensure tests can never wipe normal application data.

🧊In regards to what you said about OOP, I think the classes you created were appropriate. This is something that comes with experience. But a good rule of thumb is: Is this class doing one type of thing only? If it's doing a lot (i.e. handling UI, data access, helper methods, etc), it should be split.

🗺️ I noticed that the only courses you've completed so far are Introduction to Object-Oriented Programming and Intro to SQL. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants