Skip to content

Initial pull request - #289

Closed
dofelor wants to merge 2 commits into
the-csharp-academy:mainfrom
dofelor:main
Closed

dofelor wants to merge 2 commits into
the-csharp-academy:mainfrom
dofelor:main

Conversation

@dofelor

@dofelor dofelor commented Sep 29, 2026

Copy link
Copy Markdown

No description provided.

dofelor and others added 2 commits September 29, 2026 10:36
Added project overview and architecture details.
@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@dofelor Project approved! Apologies for the delay😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. Keep in mind that it's a very competitive environment out there in the software development industry. I highly recommend you do everything in your power to stand out from the competition. 👩‍🎤

🥋And congratulations! You got your Olive Green belt!! 🫒🫒

Feedback
💖 It's great that you're letting users hit enter to keep a value when updating. A step further would be to use arrows instead of ids for picking a record.

⚠️Currently, GetDateTimeInput() uses DateTime.TryParse(), while the prompt accepts examples such as both 14:00 and 2026-09-27 14:00. TryParse() is deliberately flexible, so many other formats can also pass validation. Use DateTime.TryParseExact() with one chosen format, such as yyyy-MM-dd HH:mm, instead.

🔍I found a bug where shifts spanning multiple days don't show the correct duration:
image

🔍One architecture note: CodingSessionsRepository : BaseController isn't necessary. The repository doesn't use the display/input functionality of BaseController, and the data-access layer ideally shouldn't inherit UI/controller behavior. I'd simply make it CodingSessionsRepository : ICodingSessionsRepository.

🗺️ I noticed that the only courses you've completed so far are Introduction to Object-Oriented Programming and Intro to SQL. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants