Repository navigation
Project Done - #292
Project Done #292FeedMyData wants to merge 49 commits into
Conversation
Would like the seeding to increment activities and not pick them randomly
With Logic to filter by category or activity not tested
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@FeedMyData Thanks for submitting. Looks like you've deleted .gitignore so now all obj/bin folders are showing. Please reinstate git ignore. You can see in the picture below the PR got cluttered with unnecessary files:
It's a good learning opportunity as ultimately you should always check to prevent unnecessary files from being committed.
💁♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.
|
Thanks for reviewing. I reinstalled a .gitignore file and deleted unecessary files in "\obj" and "\bin" |
|
@FeedMyData Thanks for the clean up! Project approved! This is an ambitious implementation with a well-organized structure, CRUD operations, Dapper, Spectre.Console, and a live stopwatch. The UI is very easy to use and I like that you let users update a single property 💪💪 I agree with the points you brought up in your Readme. DateTime is notoriously painful as it's very hard to get it right. There are time zones, cultures, formatting, conversions. That's one of the main purposes of this project. 😊Planning your project before hand is also a great idea, even if it's a high level design. But be careful not to overdo it, it's very hard to foresee everything. And most importantly. You don't need to learn things by heart. You need instead to know how things work, how to solve problems and where to find answers. 😊 🥋And congratulations! You got your Olive Green belt!! 🫒🫒 Feedback 🔍In UserInterface.EditItem(), the code for editing only the start time contains: However, selection.EndTime contains a full date and time, while FormatTimeInfo() expects only an hour for its third argument. This can cause parsing errors. 🔍Your LiveSession supports pausing and resuming, which is great. However, you're storing: alongside: When the user pauses the session, the elapsed stopwatch time no longer equals the difference between the start and end timestamps. For example, a session could start at 10:00, finish at 11:00, and record only 30 minutes of active coding. 🗺️ I noticed that the only course you've completed so far is Introduction to Object-Oriented Programming. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive. ☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂 Overall good work!✋🏻Looking forward to seeing your next projects! |
|
Thanks again for the thorough feedback. Definitely gonna do the Unit tests! You are right regarding the inconstancy, I kinda forgot about it. |
Challenges
Thanks again for your time Pablo!