Skip to content

MathGameProject - "Trust Me, It's 32" - #777

Closed
Roknikk wants to merge 1 commit into
the-csharp-academy:mainfrom
Roknikk:main
Closed

Roknikk wants to merge 1 commit into
the-csharp-academy:mainfrom
Roknikk:main

Conversation

@Roknikk

@Roknikk Roknikk commented Sep 26, 2026

Copy link
Copy Markdown

I had so much fun working on this little project that I even decided to give it a silly name: "Trust Me, It's 32. All your comments will be appreciated.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

TheCSharpAcademy commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

@Roknikk Project approved! 😄✅ And well done for completing some of the challenges! I recommend you always do that, as it pushes you and makes you learn faster. Your project is clean, tidy, concise and to the point. And you're using only one method for all operations, great work!

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️While not wrong, it's unnecessary to use a list within a list. It makes it harder to read, debug and maintain. Use a List of a custom type.
image

🔍️The stopwatch is never reset. Stop() pauses a stopwatch; it doesn't set its elapsed time back to zero. Therefore, if the first game takes 30 seconds and the second takes 20 seconds, the second game's reported time will be around 50 seconds.

🕵️‍♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of unnecessary comments, as per picture below. You can read our code conventions here🤓.
image

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants