Skip to content

FirstSubmission - math game - #781

Closed
sonata7245 wants to merge 2 commits into
the-csharp-academy:mainfrom
sonata7245:main
Closed

sonata7245 wants to merge 2 commits into
the-csharp-academy:mainfrom
sonata7245:main

Conversation

@sonata7245

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonata7245 Thanks for submitting! Could you please fix this missing requirements?

⚠️ Operation menu: You allow the user to type an operand, but don't actually present the valid operations as a menu. Since the requirement specifically says users should be presented with a menu to choose an operation.

⚠️ At least 5 questions: This is the blocker. You let the user choose numQuestions, but there's no validation enforcing a minimum of five.

Image Image

Once you make the changes just commit them. You don't need a new pull request. 😁

💁‍♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.

@TheCSharpAcademy TheCSharpAcademy self-assigned this Oct 2, 2026
Updated input prompts to specify constraints for questions and operands. Added validation loops for user inputs.
@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@sonata7245 Sorry I'm writing this again because I had posted a comment about another project. Project approved! 😄✅Thanks for making the fixes.

🥋And congratulations! You got your Green belt!! 🟢🟢

Feedback
🔍You're validating against question count under 5 but it would be good to show an error message instead of just asking for another input. The same happens when I input an invalid option in the menu of operations.

image

🔍️ If I input a string the app crashes. It's better to use TryParse() and handle null then using Parse(). The same happens if I input a string when answering a question.
image

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants