Skip to content

Math Game by yojjal - #782

Closed
yojjal060 wants to merge 4 commits into
the-csharp-academy:mainfrom
yojjal060:main
Closed

yojjal060 wants to merge 4 commits into
the-csharp-academy:mainfrom
yojjal060:main

Conversation

@yojjal060

Copy link
Copy Markdown

No description provided.

Copilot AI balanced review requested due to automatic review settings October 4, 2026 14:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@yojjal060 Project approved! 😄✅ And well done for completing one of the challenges! You completed an extra feature by allowing the player to choose how many questions they want, while enforcing the five-question minimum, 💪 I recommend you try the other challenges eventually, to reinforce your learning 😁

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️ When checking for number of questions, in case the input is incorrect I'm sent back to the main menu. Ideally you'd want the users to try again.

🔍️Still when choosing the number of questions, it would be good to have a maximum input as well, say 5 to 20.

🔍When answering questions and choosing the number of questions, pressing enter crashes the app. Avoid using Parse() in general. TryParse() is safer.

image

🕵️‍♀️Also, have a look at our style guide since there are a few issues in your code. e.g. unused usings and unnecessary empty spaces, as per picture below. You can read our code conventions here🤓.

image

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 And do you mind adding a country in your profile as well? The dashboard and leaderboard look neater when there's a flag. If you're not comfortable with that you can submit a random country.

Overall good work!✋🏻Looking forward to seeing your next projects!

@TheCSharpAcademy TheCSharpAcademy self-assigned this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants