Repository navigation
Project Finished! - #783
EternalWanderer7 wants to merge 4 commits into
Conversation
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
TheCSharpAcademy
left a comment
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@EternalWanderer7 Thanks for submitting! Before we can approve could you please fix this missing requirement?
Additionally a couple more improvements could be made:
🔍For better readability, clear the console more often or at least add some spacing as the UI is getting crammed.
🔍️ I highly recommend you learn about the DRY Principle (Don't Repeat Yourself) . There's a fair bit of repetition in the operations methods. You could have a single method for all operations, using variables for each operation.
💁♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.
|
That should be good. Sorry it took so long; I had to study for midterms. Please review it when you can. |
|
@EternalWanderer7 Project approved! 😄✅ Thanks for making the changes and well done for completing the difficulty challenges! I recommend you always do that, as it pushes you and makes you learn faster. Your project is clean, tidy, concise and to the point. And you're using only one method for all operations, great work! 🥋And congratulations! You got your green belt!! 🟩🟩 Feedback 
🔍️As you can see above you named your variable "a" and "b", which mean nothing. Make sure you name your properties properly to 🔍For better readability clean the console more often, as it gets cluttered quickly. 🕵️♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of unused usings, as per picture below. You can read our code conventions here🤓. 
Overall good work!✋🏻Looking forward to seeing your next projects! |
I had a lot of fun revising my C# knowledge with this project. It showed me what I already knew and what I didn't know before. It also helped me learn how to use GitHub efficiently as well. Please review this critically so I can learn even more about C# and project development.