Skip to content

C-Sharp-Academy project ready for review - #786

Closed
HilbersLiam wants to merge 1 commit into
the-csharp-academy:mainfrom
HilbersLiam:main
Closed

HilbersLiam wants to merge 1 commit into
the-csharp-academy:mainfrom
HilbersLiam:main

Conversation

@HilbersLiam

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

TheCSharpAcademy commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

@HilbersLiam Project approved! 😄✅ The project is clean and tidy and you meet all requirements. It's a shame you didn't complete the challenges other than the timer. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later.

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️ Currently, if the user enters something other than 1 through 6, the application silently returns to the menu.
Consider adding a default case to handle bad inputs.

🔍️Inside CalculateResult(), you have:
``
DateTime startTime = DateTime.UtcNow;
return 0;

``
The startTime variable isn't used and should be removed.

🔍You could also simplify your calculation method using a switch expression. This is optional, but it's a nice opportunity to learn modern C# syntax:

int CalculateResult(int num1, int num2, string operation)
{
    return operation switch
    {
        "+" => num1 + num2,
        "-" => num1 - num2,
        "*" => num1 * num2,
        "/" => num1 / num2,
        _ => throw new ArgumentException("Invalid operation")
    };
}

🔍Adding the date and time a game was played would make the history feature more informative.

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants